Skip to content

deliver whats-new info also to pre-releases #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Aug 16, 2018
Merged

deliver whats-new info also to pre-releases #138

blizzz merged 1 commit into from
Aug 16, 2018

Conversation

@blizzz
Copy link
Contributor

@blizzz blizzz commented Aug 16, 2018

No description provided.

@blizzz blizzz requested a review from rullzer August 16, 2018 10:22
rullzer
rullzer approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could have also gone for <= ;)

@blizzz
Copy link
Contributor Author

blizzz commented Aug 16, 2018

@rullzer nope, <= wouldn't help:

var_dump(version_compare('14.0.0 Beta 4', '14.0.0', '<='));
bool(true)

true goes return.

@blizzz blizzz merged commit 61d3de7 into master Aug 16, 2018
@blizzz blizzz deleted the whatsnew-preleases branch August 16, 2018 10:53
@blizzz blizzz mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rullzer rullzer rullzer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz @rullzer