Improve UX when node job fails because of assets #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an explicit message about recompiling to avoid scratching heads. Also highlight "Show changes on failure" in red so that it catches the eye because it's easy to miss while scratching head. Signed-off-by: Vincent Petry <[email protected]>
nickvergessen
approved these changes
Aug 3, 2022
delete-merged-branch
bot
deleted the
bugfix/noid/improve-ux-on-node-fail
branch
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explicit message about recompiling to avoid scratching heads.
Also highlight "Show changes on failure" in red so that it catches the
eye because it's easy to miss while scratching head.
Before:
After:
Note: I have changed the message since the screenshot, but you get the point.
Background:
This is a follow up on my frustration in nextcloud/recommendations#514 (comment) as I wasn't aware that asset compilation was required also for this repo because we don't have it elsewhere.