Update polyfill #10
Update polyfill #10
Conversation
|
The diff looks confusing, because the polyfill stuff actually didn't change, just the dependency of those? |
|
Yes it seem so. It is just a version bump with some dep upgrades as I understand it. |
|
Just want to get 3rdparty deps a bit more in shape again ;) |
| "require": { | ||
| "php": ">=5.3.3", | ||
| "paragonie/random_compat": "~1.0" | ||
| "paragonie/random_compat": "~1.0|~2.0" |
There was a problem hiding this comment.
I wouldn't bump to 2.0. This breaks compatibility: https://github.com/paragonie/random_compat/blob/master/CHANGELOG.md#version-200---2016-03-18
There was a problem hiding this comment.
That is the dep of our dep, not a file we touch
There was a problem hiding this comment.
Yeah. But using 2.0 here will break stuff. We can't take that. Sorry 👎
There was a problem hiding this comment.
Also see the diff above, the 1.0 version has been replaced with 2.0. We should keep 1.0.x here for now.
There was a problem hiding this comment.
Basically with 2.0 instances where /dev/urandom is not readable will fail pretty hard ;)
|
👍 |
|
Since we drop the 5.4 and 5.5 support we can drop polyfill 5.5 snd 5.6? |
See #11 ;) |
No description provided.