Migrate from opis/closure to laravel/serializable-closure #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
We will need to keep both dependencies for migration purposes. We can drop opis/closure in a few releases. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/replace-opis-closure-by-laravel-fork
branch
from
b74877c to
b5f73e9
Compare
blizzz
approved these changes
Jun 21, 2022
Contributor
Author
|
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See opis/closure#107
Opis/closure 3.x will never support PHP>8.0
Opis/closure 4.x relies on FFI which sounds like too strong a requirement.
Laravel maitains a fork: https://github.com/laravel/serializable-closure
Signed-off-by: Côme Chilliet [email protected]