chore(deps): Bump doctrine/dbal from 3.8.3 to 4.0.4

[dependabot]

Bumps doctrine/dbal from 3.8.3 to 4.0.4.

Release notes

Sourced from doctrine/dbal's releases.

4.0.4

Release Notes for 4.0.4

4.0.4

• Total issues resolved: 0
• Total pull requests resolved: 2
• Total contributors: 1

Test Suite

• 6454: PHPUnit 10.5.22 thanks to @​derrabus
• 6447: PHPUnit 10.5.21 thanks to @​derrabus

Changes from Lower Branches

• This release contains all changes of the 3.8.6 release.

4.0.3

Release Notes for 4.0.3

4.0.3

• Total issues resolved: 0
• Total pull requests resolved: 6
• Total contributors: 5

Test Suite

• 6431: Display warnings when running PHPUnit in CI thanks to @​stof
• 6400: PHPUnit 10.5.20 thanks to @​derrabus

Bugfix

• 6418: Fix foreign key name change detection thanks to @​achterin

Static Analysis

• 6401: Psalm 5.24.0 thanks to @​derrabus

Documentation

• 6394: Fix example for QB delete and update in doc block thanks to @​Metabor

Code Style

... (truncated)

Upgrade guide

Sourced from doctrine/dbal's upgrade guide.

Note about upgrading: Doctrine uses static and runtime mechanisms to raise awareness about deprecated code.

• Use of @deprecated docblock that is detected by IDEs (like PHPStorm) or Static Analysis tools (like Psalm, phpstan)
• Use of our low-overhead runtime deprecation API, details: https://github.com/doctrine/deprecations/

Upgrade to 4.0

BC BREAK: removed AbstractMySQLPlatform methods.

1. getColumnTypeSQLSnippets(),
2. getDatabaseNameSQL().

BC BREAK: Removed lock-related AbstractPlatform methods

The methods AbstractPlatform::getReadLockSQL(), ::getWriteLockSQL() and ::getForUpdateSQL() have been removed Use QueryBuilder::forUpdate() as a replacement for the latter.

BC BREAK: BIGINT values are cast to int if possible

BigIntType casts values retrieved from the database to int if they're inside the integer range of PHP. Previously, those values were always cast to string.

BC BREAK: Stricter DateTime types

The following types don't accept or return DateTimeImmutable instances anymore:

• DateTimeType
• DateTimeTzType
• DateType
• TimeType
• VarDateTimeType

As a consequence, the following type classes don't extend their mutable counterparts anymore:

• DateTimeImmutableType
• DateTimeTzImmutableType
• DateImmutableType
• TimeImmutableType
• VarDateTimeImmutableType

BC BREAK: Remove legacy execute and fetch methods.

The following methods have been removed:

• Result::fetch()
• Result::fetchAll()

... (truncated)

Commits

• 50fda19 PHPUnit 10.5.22 (#6454)
• 05db10b Merge branch '3.8.x' into 4.0.x
• b741182 PHP CodeSniffer 3.10.1 (#6453)
• 0b66bc8 Merge branch '3.8.x' into 4.0.x
• e91630d PHPUnit 10.5.21 (#6447)
• a0c9416 Move schema split for SQLite CREATE INDEX only (#6352)
• 032d902 PHPStan 1.11.5 (#6446)
• 18ccd5b Merge pull request #6445 from dmaicher/revert-6413
• aa96737 Revert "Merge pull request #6413 from achterin/bugfix/foreign_key_name_change...
• 8edbce7 Merge pull request #6436 from greg0ire/4.0.x
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[susnux]

For us relevant:

• Requires PHP 8.1+ (we currently support 8.0+)
• Requires MariaDB 10.5+ (we currently support 10.3 and 10.5+)

[nickvergessen]

Requires PHP 8.1+ (we currently support 8.0+)

Not for master:
https://github.com/nextcloud/server/blob/master/lib/versioncheck.php#L11

Requires MariaDB 10.5+

So we will have to drop that one and just make sure people are aware up front.

[nickvergessen]

https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md

Has some more presents:

• The Doctrine\DBAL\Exception and the Doctrine\DBAL\Schema\SchemaException classes are now interfaces.
• The following Table methods have been removed:
  • changeColumn(),
  • getForeignKeyColumns(),
  • getPrimaryKeyColumns(),
  • hasPrimaryKey()
• removed wrapper- and driver-level Statement::bindParam() methods.
• renamed SQLite platform classes (should try to add abstraction on our end)
• The number of affected rows is returned as int|string
• Dropped support for collate option for MySQL
• Removed Connection::getWrappedConnection()
• Statement::execute() marked private.
• Removed QueryBuilder methods and contstants.
• Removed ExpressionBuilder methods: The andX() and orX() …
  • (our abstraction might save us from breaking apps)
• Changes in the QueryBuilder API
  • (our abstraction might save us from breaking apps)
• Changes in the Doctrine\DBAL\Schema API: Column precision no longer defaults to 10. The default value is NULL.
• Connection::connect(), ::bindValue() and ::execute() no longer return a boolean value. They will throw an exception in case of failure.

[nickvergessen]

/composer-update

[dependabot]

A newer version of doctrine/dbal exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[jaylinski]

@nickvergessen I suggest to update to https://github.com/doctrine/dbal/releases/tag/3.9.5. It still supports PHP 7.4 and 8.0 and recently got support for MariaDB 11.8, which is needed for nextcloud/server#51596.

[nickvergessen]

It only added it to the testing matrix, or was there a change below?

[susnux]

@dependabot recreate

[dependabot]

Superseded by #2089.