Skip to content

[stable28] chore: set version in composer.json #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 1 commit into from
Jul 4, 2024
Merged

[stable28] chore: set version in composer.json #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: set version in composer.json 
When running dump-autoload, then composer tries to find a matching version number.

Sometimes the VCS detection does not work and the generated version number changes from the commit hash to the fallback and back to the generated version when someone else updates the package.

We are now using a version number in composer.json to avoid a version number ping-pong.

Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Jul 4, 2024
commit 1ca99e0ce2133749028e2dc920e26e018eacd3e7
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "nextcloud/3rdparty",
"version": "dev-stable28",
"description": "All 3rdparty components",
"license": "MIT",
"config": {
Expand Down
82 changes: 50 additions & 32 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions composer/installed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php return array(
'root' => array(
'name' => 'nextcloud/3rdparty',
'pretty_version' => 'dev-master',
'version' => 'dev-master',
'reference' => '6b178ba78e6e56dda78f3eec92e60d79e0812c99',
'pretty_version' => 'dev-stable28',
'version' => 'dev-stable28',
'reference' => NULL,
'type' => 'library',
'install_path' => __DIR__ . '/../',
'aliases' => array(),
Expand Down Expand Up @@ -308,9 +308,9 @@
'dev_requirement' => false,
),
'nextcloud/3rdparty' => array(
'pretty_version' => 'dev-master',
'version' => 'dev-master',
'reference' => '6b178ba78e6e56dda78f3eec92e60d79e0812c99',
'pretty_version' => 'dev-stable28',
'version' => 'dev-stable28',
'reference' => NULL,
'type' => 'library',
'install_path' => __DIR__ . '/../',
'aliases' => array(),
Expand Down