feat(s3): Avoid shipping unused services #2102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh <[email protected]>
Member
Author
|
/composer-update |
Signed-off-by: nextcloud-command <[email protected]>
Contributor
|
Thanks 🙏 That looks like a good thing. I will prepare the companion PR for server, and then we will know what the CI thinks ;) |
4 tasks
susnux
approved these changes
Jul 20, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Could only be a problem if an app uses one of the services. Or want to use it and then installs this dependency themself, no?
Member
I think we can do this, if someone comes up with a valid usecase we can rethink it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use S3. No reason to ship code for 300+ unused services in our release artifact.
aws/aws-sdk-php#2456
https://github.com/aws/aws-sdk-php/tree/master/src/Script/Composer