fix: mp3info break frame parsing on short frames #2182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We are using https://github.com/cweagans/composer-patches for patching dependencies. Please commit the patch file like in #1888. |
grnd-alt
force-pushed
the
fix/break-mp3-parse-on-invalid-frame
branch
from
f9afab0 to
edccd92
Compare
kesselb
force-pushed
the
fix/break-mp3-parse-on-invalid-frame
branch
from
edccd92 to
f3f6324
Compare
Signed-off-by: grnd-alt <[email protected]> Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
fix/break-mp3-parse-on-invalid-frame
branch
from
f3f6324 to
3f8e17c
Compare
Contributor
|
I've updated the patch file and run compose install --no-dev (the ci will not pass with dev dependencies). While we are on it, do you think we should also apply wapmorgan/Mp3Info@37365fd (commit to master, but unreleased)? |
Signed-off-by: grnd-alt <[email protected]>
kesselb
approved these changes
Nov 10, 2025
Member
|
Need a server PR companion to check it actually |
Member
|
WRong button sorry, wanted to only comment |
Member
Author
|
@nickvergessen companion pr: nextcloud/server#56436 |
7 tasks
juliusknorr
approved these changes
Nov 18, 2025
Member
|
Backports needed? |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch of our upstream pr waiting for review:
wapmorgan/Mp3Info#40