Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jan 14, 2022

Backport of #937. This is needed because it fixes compatibility with PHP 8 which is supported by Nextcloud 21, 22 and 23.

I wasn't sure which changes need to be committed so I just included all changes. I followed the guide at #937 (comment).

@st3iny st3iny self-assigned this Jan 14, 2022
@st3iny st3iny changed the title Bump christophwurst/id3parser to 0.1.4 [stable21] Bump christophwurst/id3parser to 0.1.4 Jan 14, 2022
@come-nc
Copy link
Contributor

come-nc commented Jan 17, 2022

Several problems here, the tests are in the autoloader, and the dev mode is put to true.

Here is my script for bumping:

#!/bin/sh

# Stop at first error
set -e

package=$1
version=$2

# Make sure that we are in the right folder
git remote show origin|grep [email protected]:nextcloud/3rdparty.git

# Edit composer.json and adjust the version of the library to the one to update to
composer require -W $package:^$version
# Run composer update thevendor/thelib
composer update $package
# Delete all installed dependencies with rm -rf ./*/
rm -r ./*/
# Run composer install --no-dev
composer install --no-dev
# Remove tests and other ignored files
git clean -X -d -f
# Run dump-autoload
composer dump-autoload

Comment on lines +2091 to +2099
'Pimple\\Tests\\Fixtures\\Invokable' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/Fixtures/Invokable.php',
'Pimple\\Tests\\Fixtures\\NonInvokable' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/Fixtures/NonInvokable.php',
'Pimple\\Tests\\Fixtures\\PimpleServiceProvider' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/Fixtures/PimpleServiceProvider.php',
'Pimple\\Tests\\Fixtures\\Service' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/Fixtures/Service.php',
'Pimple\\Tests\\PimpleServiceProviderInterfaceTest' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/PimpleServiceProviderInterfaceTest.php',
'Pimple\\Tests\\PimpleTest' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/PimpleTest.php',
'Pimple\\Tests\\Psr11\\ContainerTest' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/Psr11/ContainerTest.php',
'Pimple\\Tests\\Psr11\\ServiceLocatorTest' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/Psr11/ServiceLocatorTest.php',
'Pimple\\Tests\\ServiceIteratorTest' => $vendorDir . '/pimple/pimple/src/Pimple/Tests/ServiceIteratorTest.php',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop?

@nickvergessen
Copy link
Member

stable21 is currently in freeze

@come-nc come-nc removed their request for review May 5, 2022 14:47
@st3iny
Copy link
Member Author

st3iny commented Jun 3, 2022

Not required anymore.

@st3iny st3iny closed this Jun 3, 2022
@st3iny st3iny deleted the fix/update-id3parser/stable21 branch June 3, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants