Skip to content

Conversation

@ArtificialOwl
Copy link
Member

backport of #992

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Jan 4, 2023

@icewind1991 second review ?

@blizzz
Copy link
Member

blizzz commented Jan 17, 2023

Still needed?

@PVince81
Copy link
Member

@ArtificialOwl can you fix DCO ? maybe rebase then to get a fresh CI run

@ArtificialOwl ArtificialOwl force-pushed the backport/992/992-stable23 branch from 5780dd9 to beaf020 Compare February 1, 2023 02:26
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the backport/992/992-stable23 branch from beaf020 to cb8e4a9 Compare February 1, 2023 12:19
@blizzz
Copy link
Member

blizzz commented Feb 6, 2023

@ArtificialOwl Cypress is unrelated?

@artonge
Copy link
Collaborator

artonge commented Feb 9, 2023

Cypress tests are unrelated.

@blizzz blizzz merged commit 9ab7716 into stable23 Feb 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/992/992-stable23 branch February 9, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants