Skip to content

Create headings for sidebar pages #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Mar 8, 2023
Merged

Create headings for sidebar pages #1081

JuliaKirschenheuter merged 1 commit into from
Mar 8, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Feb 10, 2023 •
edited
Loading

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Feb 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from 231e6b2 to 0e1df7d Compare February 10, 2023 13:42
nickvergessen
nickvergessen previously requested changes Feb 10, 2023
View reviewed changes
@nickvergessen
Copy link
Member

nickvergessen commented Feb 10, 2023

Where is the section defined. I assume a generic PR in server? How is ensured that it is not added when there is an h1 already.
Why are the words "Section" and "Subsection" added? That feels so wrong and unneeded.
If it would be helpful we could make activity filters have defining a "Activitiy by others" h2 title additional to the link name.
But the current wording really sound like a quirk/hack?🤔

@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 10, 2023

/backport to stable25

@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft February 13, 2023 14:41
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Feb 13, 2023
Closed
9 tasks
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch 2 times, most recently from 65ca0af to 3b9e51a Compare March 2, 2023 10:55
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review March 2, 2023 10:57
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Mar 3, 2023

/backport to stable26

@nickvergessen nickvergessen removed their request for review March 7, 2023 06:19
@JuliaKirschenheuter
Create headings for sidebar pages
eab9671 
Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from 6f96282 to eab9671 Compare March 8, 2023 07:20
@nickvergessen nickvergessen dismissed their stale review March 8, 2023 08:21

Dismissing

@JuliaKirschenheuter JuliaKirschenheuter merged commit 2048c62 into master Mar 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/35626-No_heading_nor_tab_index_for_settings_pages branch March 8, 2023 08:22
This was referenced Mar 8, 2023
Merged
Merged
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Mar 9, 2023
Closed
2 tasks
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@nickvergessen nickvergessen nickvergessen left review comments

@szaimen szaimen Awaiting requested review from szaimen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JuliaKirschenheuter @nickvergessen @artonge @Pytal