fix: Properly import the ActivityTab dynamically #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
artonge,
marcelklehr and
nickvergessen
and removed request for
marcelklehr
Member
Author
|
/backport to stable26 |
Signed-off-by: Julius Härtl <[email protected]>
Member
Author
|
FYI @AndyScherzinger Might be good to still have the backport of this in rc2 as without the files activity sidebar is not working. |
marcelklehr
approved these changes
Mar 9, 2023
Member
marcelklehr
left a comment
marcelklehr
left a comment
There was a problem hiding this comment.
huh, makes sense. I wonder why my tests didn't catch this :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamic imports return the imported component as { default }. This fixes loading the activity sidebar in files.