Check if users is set #1281
Closed
Check if users is set #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Aug 18, 2023
Collaborator
|
In which case can it be empty? Do you have reproduction steps? |
Member
Author
|
No sorry, just some errors like these in the logs... |
Collaborator
|
I am wondering if this won't juste hide another issue. Can you investigate ? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
|
Maybe. Do you still have the log? |
nickvergessen
previously requested changes
Dec 18, 2023
Member
Author
|
This will also fix: Can we go ahead and merge + backport it? |
Contributor
|
I think this should be fixed in |
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
This was referenced Apr 4, 2024
Signed-off-by: Git'Fellow <[email protected]> Fix psalm Signed-off-by: Git'Fellow <[email protected]> Use empty array if array is unset Signed-off-by: Git'Fellow <[email protected]>
2 flaky tests on run #1518 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has favorite activity |
Test Replay
Screenshots
|
|
| Check activity listing in the sidebar > Has share activity |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1281 ↗︎
Contributor
I think this is still valid to not just hide issues |
Contributor
Member
Author
|
Maybe, but as long as I don't see this in logs a long time ago, and this PR is not the good approach anyway, closing here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Undefined array key "users"
Exception: array_keys(): Argument #1 ($array) must be of type array, null given