Skip to content

[stable27] perf(dashboard): implement widget item api v2 #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Sep 8, 2023
Merged

[stable27] perf(dashboard): implement widget item api v2 #1299

ChristophWurst merged 1 commit into from
Sep 8, 2023

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Sep 5, 2023

Manual backport of #1284

Tested locally and works.

@st3iny st3iny added this to the Nextcloud 27.1.0 milestone Sep 5, 2023
@st3iny st3iny self-assigned this Sep 5, 2023
@st3iny st3iny changed the title perf(dashboard): implement widget item api v2 [stable27] perf(dashboard): implement widget item api v2 Sep 5, 2023
@blizzz blizzz mentioned this pull request Sep 5, 2023
Merged
6 tasks
@blizzz
Copy link
Member

blizzz commented Sep 6, 2023

@st3iny some CI is read including static analysis. Please check.

@st3iny
Copy link
Member Author

st3iny commented Sep 6, 2023 •
edited
Loading

The phpunit job fails with a transient error during composer install (not able to unzip a zip file). I restarted all failed jobs.

The static analysis job failure seems to be a false alarm. My guess is that is not using the most recent version of nextcloud/ocp that contains the right interfaces. The interface IReloadableWidget clearly exists on server master and stable27.

https://github.com/nextcloud/server/blob/master/lib/public/Dashboard/IReloadableWidget.php
https://github.com/nextcloud/server/blob/stable27/lib/public/Dashboard/IReloadableWidget.php

@AndyScherzinger AndyScherzinger force-pushed the perf/dashboard/item-api-v2-stable27 branch from 9570136 to 31e02bf Compare September 7, 2023 07:30
@ChristophWurst ChristophWurst mentioned this pull request Sep 7, 2023
Merged
1 task
@blizzz blizzz mentioned this pull request Sep 8, 2023
Merged
@ChristophWurst ChristophWurst force-pushed the perf/dashboard/item-api-v2-stable27 branch from 31e02bf to 11ace72 Compare September 8, 2023 10:35
@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 8, 2023

CI should be fixed 🤞

@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 8, 2023

It passes

@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 8, 2023

@artonge @miaulalala maintainer approval? then :shipit:

RC blocking is to be bypassed because this change is planned for 27.1.0

@ChristophWurst ChristophWurst merged commit 09459b6 into stable27 Sep 8, 2023
@ChristophWurst ChristophWurst deleted the perf/dashboard/item-api-v2-stable27 branch September 8, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@artonge artonge Awaiting requested review from artonge

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@st3iny st3iny

Labels

3. to review enhancement

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 27.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@st3iny @blizzz @ChristophWurst @AndyScherzinger @come-nc