fix(sidebar): Only load chunk once #1363
Conversation
Signed-off-by: Ferdinand Thiessen <[email protected]>
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
So it was loaded whenever the sidebar was opened ?
|
Signed-off-by: Ferdinand Thiessen <[email protected]>
| iconSvg: LightningBolt, | ||
|
|
||
| async mount(el, fileInfo, context) { | ||
| const { default: ActivityTab } = await import(/* webpackPreload: true */ './views/ActivityTab.vue') |
There was a problem hiding this comment.
Huh, webpack doesn't cache the chunk here? That's weird.
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Only load the chunk if needed (yes it might be cached but we do not need to try this).