Skip to content

feat(sidebar): Add frontend API that allows to register custom entries #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 7 commits into from
Nov 15, 2023
Merged

feat(sidebar): Add frontend API that allows to register custom entries #1416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
119f6e4
feat(sidebar): Add API to register custom actions to activity tab
susnux Nov 7, 2023
988afc0
feat(comments): Show user avatar instead of app icon
susnux Nov 14, 2023
8420d2f
feat(sidebar): Allow to register filters and custom entries
susnux Nov 15, 2023
7119243
fix(tests): Reduce warnings while testing
susnux Nov 15, 2023
cb8f57f
chore: Add missing license headers and split types from implementation
susnux Nov 15, 2023
0ab1a4f
chore: compile assets
susnux Nov 14, 2023
68ed595
chore(assets): Recompile assets
nextcloud-command Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tests): Reduce warnings while testing 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Nov 15, 2023
commit 7119243fabf27ce87d33d39a5ddb172683d94e95
28 changes: 14 additions & 14 deletions src/__tests__/Activity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import ActivityModel from '../models/ActivityModel.js'

import wsData from '../__mocks__/@nextcloud/activity_ws.json'

const currentDate = new Date('2021-05-10T12:00:00+00:00')
const currentDate = new Date('2021-05-02T12:00:00+00:00')
const realDateNow = Date.now

beforeAll(() => {
Expand All @@ -50,23 +50,23 @@ const expectLinkWithText = (wrapper, text) => {
}

test('Display relative date gets updated every minutes', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[1]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[1]), showPreviews: true } })
expect(wrapper.text()).toContain('You renamed Test file - renamed.md to Test file - renamed - looooooooong.md')

expect(wrapper.find('[data-testid="activity-date"]').text()).toContain('11 days ago')
expect(wrapper.find('[data-testid="activity-date"]').text()).toContain('3 days ago')

const currentDatePlusOneDay = new Date('2021-05-11T12:00:00+00:00')
const currentDatePlusOneDay = new Date('2021-05-03T12:00:00+00:00')
window.Date.now = vi.fn(() => currentDatePlusOneDay.getTime())

vi.advanceTimersByTime(60 * 1000)
await nextTick()
expect(wrapper.find('[data-testid="activity-date"]').text()).toContain('12 days ago')
expect(wrapper.find('[data-testid="activity-date"]').text()).toContain('4 days ago')

window.Date.now = vi.fn(() => currentDate.getTime())
})

test('Display correct information for renames', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[1]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[1]), showPreviews: true } })

expect(wrapper.text()).toContain('You renamed Test file - renamed.md to Test file - renamed - looooooooong.md')

Expand All @@ -75,46 +75,46 @@ test('Display correct information for renames', async () => {
})

test('Display correct information for comments', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[4]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[4]), showPreviews: true } })

expect(wrapper.text()).toContain('You commented')

expect(wrapper.text()).toContain('A comment')
})

test('Display correct information for favorites', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[5]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[5]), showPreviews: true } })

expect(wrapper.text()).toContain('Added to favorites')
})

test('Display correct information for unfavorites', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[6]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[6]), showPreviews: true } })

expect(wrapper.text()).toContain('Removed from favorites')
})

test('Display correct information for changes', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[7]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[7]), showPreviews: true } })

expect(wrapper.text()).toContain('You changed Test file - renamed.md')

expectLinkWithText(wrapper, 'Test file - renamed.md')
})

test('Display correct information for tags', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[9]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[9]), showPreviews: true } })

expect(wrapper.text()).toContain('Added system tag tag1')
})

test('Display correct information for shares', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[10]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[10]), showPreviews: true } })
expect(wrapper.text()).toContain('Shared as public link')
})

test('Display correct information for moves', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[14]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[14]), showPreviews: true } })

expect(wrapper.text()).toContain('You moved Test file.md to Documents')

Expand All @@ -123,7 +123,7 @@ test('Display correct information for moves', async () => {
})

test('Display correct information for creations', async () => {
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[17]) } })
const wrapper = mount(Activity, { propsData: { activity: new ActivityModel(wsData.ocs.data[17]), showPreviews: true } })

expect(wrapper.text()).toContain('You created Test file.md')

Expand Down
1 change: 1 addition & 0 deletions src/views/ActivityTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<Activity v-for="activity in activities"
:key="activity.id"
:activity="activity"
:show-previews="false"
@reload="getActivities()" />
</ul>
</template>
Expand Down