Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

Fixes #1464

Before After
Screenshot from 2024-01-15 16-28-17 Screenshot from 2024-01-15 16-23-08

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 15, 2024
@JuliaKirschenheuter JuliaKirschenheuter changed the title Fix/1464 adapt visual your activities <h1> which remains the same through all activities pages Фdapt visual your activities <h1> which remains the same through all activities pages Jan 15, 2024
@JuliaKirschenheuter JuliaKirschenheuter changed the title Фdapt visual your activities <h1> which remains the same through all activities pages Adapt visual your activities <h1> which remains the same through all activities pages Jan 15, 2024
@JuliaKirschenheuter JuliaKirschenheuter changed the title Adapt visual your activities <h1> which remains the same through all activities pages Adapt heading relied on the navigation item Jan 15, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

/compile

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1464-Adapt_visual_Your_activities_<h1>_which_remains_the_same_through_all_activities_pages branch from 462e559 to bdb4e1b Compare January 15, 2024 15:40
@cypress
Copy link

cypress bot commented Jan 15, 2024

1 flaky test on run #1137 ↗︎

0 10 0 0 Flakiness 1

Details:

Adapt heading relied on the navigation item
Project: Activity Commit: 30e09ff630
Status: Passed Duration: 04:11 💡
Started: Jan 16, 2024 9:46 AM Ended: Jan 16, 2024 9:51 AM
Flakiness  cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots

Review all test suite changes for PR #1512 ↗︎

@JuliaKirschenheuter
Copy link
Contributor Author

/compile

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1464-Adapt_visual_Your_activities_<h1>_which_remains_the_same_through_all_activities_pages branch from bdb4e1b to 2fa1859 Compare January 16, 2024 09:39
@JuliaKirschenheuter JuliaKirschenheuter merged commit d706b80 into master Jan 16, 2024
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/1464-Adapt_visual_Your_activities_<h1>_which_remains_the_same_through_all_activities_pages branch January 16, 2024 09:52
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BITV]: Adapt visual "Your activities" <h1> which remains the same through all activities pages

6 participants