MailQueueHandler: Catch provider errors #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
1 flaky test on run #1226 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has rename activity |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1545 ↗︎
artonge
reviewed
Feb 5, 2024
nickvergessen
requested changes
Feb 5, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
At least without logging this is a very bad idea. It makes it impossible to find future errors by any app in their activity handling.
Signed-off-by: Marcel Klehr <[email protected]>
artonge
approved these changes
Feb 5, 2024
nickvergessen
approved these changes
Feb 5, 2024
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport-skjnldsv to stable28 |
Member
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
It seems like part of the activity API is to allow providers to throw \InvalidArgumentExceptions when they don't recognize an event, which are now flooding the logs, because they are part of \Throwable. |
Member
Author
|
opened a PR: #1586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.