fix: unshare from group activity user handling

[susnux]

• Resolves https://github.com/nextcloud/activity/pull/1754/files#r2000854376

[susnux]

/backport to stable31

[cypress]

Activity    Run #2319

Run Properties:   Failed #2319  •  f1c6edd663: fix: unshare from group activity user handling

Project	Activity
Branch Review	fix/user-ids
Run status	Failed #2319
Run duration	03m 28s
Commit	f1c6edd663: fix: unshare from group activity user handling
Committer	Ferdinand Thiessen
View all properties for this run ↗︎

---

Test results
Failures	1
Flaky	2
Pending	0
Skipped	0
Passing	9
View all changes introduced in this branch ↗︎

---

Tests for review

  cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test		Artifacts
Check activity listing in the sidebar > Has rename activity		Screenshots

  cypress/e2e/sidebar.cy.ts • 2 flaky tests • Run E2E

View Output

Test		Artifacts
Check activity listing in the sidebar > Has share activity		Screenshots
Check activity listing in the sidebar > Has comment activity		Screenshots

[miaulalala]

Cypress failure seems related.

[come-nc]

Any idea why psalm missed it?

[susnux]

Any idea why psalm missed it?

I thought baseline but it seems to be clear...

[come-nc]

INFO: PossiblyInvalidArgument - lib/FilesHooks.php:938:25 - Parameter 1 of closure passed to function array_map expects OCP\IUser, but possibly different type OCP\IUser|string provided (see https://psalm.dev/092)
                        $userIds = array_map(fn (IUser $user) => $user->getUID(), $users);

It’s info level it seems

[susnux]

Cypress unrelated, test failed in first run succeeded in second and vice-versa.
Tests seem to be flaky as hell 😔

[come-nc]

This cannot break more things that it fixes, let’s force merge?