Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 18, 2025

No description provided.

@susnux susnux added this to the Nextcloud 32 milestone Mar 18, 2025
@miaulalala
Copy link
Collaborator

I guess the baseline needs updating?

@cypress
Copy link

cypress bot commented Mar 18, 2025

Activity    Run #2320

Run Properties:  status check passed Passed #2320  •  git commit d8a1ec23e5: chore: do not use private API (`OC`) but instead use `OCP`
Project Activity
Branch Review chore/dont-use-private-api
Run status status check passed Passed #2320
Run duration 02m 28s
Commit git commit d8a1ec23e5: chore: do not use private API (`OC`) but instead use `OCP`
Committer Ferdinand Thiessen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@susnux susnux force-pushed the chore/dont-use-private-api branch from 1454436 to 26d4bb4 Compare March 18, 2025 12:19
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextcloud/rector can do it for you

@susnux susnux merged commit 1d69d66 into master Mar 18, 2025
52 checks passed
@susnux susnux deleted the chore/dont-use-private-api branch March 18, 2025 13:34
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants