[stable30] feat: skip expire sharing notify if node deleted #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activity
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
backport/1915/stable30
|
| Run status |
|
| Run duration | 02m 58s |
| Commit |
|
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
9
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has tag activity |
Test Replay
Screenshots
|
|
cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has rename activity |
Test Replay
Screenshots
|
|
luka-nextcloud
approved these changes
Mar 21, 2025
miaulalala
force-pushed
the
backport/1915/stable30
branch
from
f3d1cbf to
0eee641
Compare
luka-nextcloud
force-pushed
the
backport/1915/stable30
branch
from
0eee641 to
2c7fff4
Compare
miaulalala
approved these changes
Mar 26, 2025
miaulalala
force-pushed
the
backport/1915/stable30
branch
from
2c7fff4 to
ca35614
Compare
Contributor
|
@miaulalala Is something wrong with cypress? |
Collaborator
It's been broken on 29 for a while now. @artonge tried to fix it but I don't know the status. I think we can force merge since it's the same failure as always (sidebar). |
Signed-off-by: Luka Trovic <[email protected]>
miaulalala
force-pushed
the
backport/1915/stable30
branch
from
ca35614 to
2da25d9
Compare
Contributor
|
@miaulalala Yes, it's not related to the code change. Could you please force merge if possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1915