-
Notifications
You must be signed in to change notification settings - Fork 68
fix(settings): ensure we handle file_created, file_deleted and file_restored as file_changed #1947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…estored as file_changed Signed-off-by: skjnldsv <[email protected]>
|
EDIT: after thoughts, could be a clean way to add child events to the |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable31 |
This comment was marked as resolved.
This comment was marked as resolved.
|
Seems like other PRs on master are failing with that cypress test, merging as unrelated |
The provider is
file_changed, but we still have some related events. But they are still covered under one setting provider: https://github.com/nextcloud/server/blob/af6de04e9e141466dc229e444ff3f146f4a34765/apps/files/lib/Activity/Settings/FileChanged.phpFix nextcloud/server#49133
Fix #1889