Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 26, 2025

The provider is file_changed, but we still have some related events. But they are still covered under one setting provider: https://github.com/nextcloud/server/blob/af6de04e9e141466dc229e444ff3f146f4a34765/apps/files/lib/Activity/Settings/FileChanged.php

image

Fix nextcloud/server#49133
Fix #1889

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 26, 2025

EDIT: after thoughts, could be a clean way to add child events to the ActivitySettings. So we know we can group them without having to hardcode them into activity.
As a fix this is fine, you can see the use case was hardcoded 4 years ago already.
But for 32, it could be a nice way. Not sure if other providers would benefit from it

@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv skjnldsv enabled auto-merge March 26, 2025 10:34
@skjnldsv
Copy link
Member Author

/backport to stable31

@cypress

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

Seems like other PRs on master are failing with that cypress test, merging as unrelated

@skjnldsv skjnldsv moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Jun 4, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

3 participants