Skip to content

[stable30] Fix multiple cypress issues #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 11 commits into from
May 26, 2025
Merged

[stable30] Fix multiple cypress issues #1996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d69020d
fix(cypress): Force click on activity tab
SystemKeeper Apr 18, 2025
5308836
chore: Enable video recording on debug
SystemKeeper Apr 18, 2025
9c70dde
fix(cypress): Extracting nextcloud logs
SystemKeeper Apr 18, 2025
d8188d9
chore: Only stop containers when not on CI
SystemKeeper Apr 18, 2025
c13cc6f
fix(cypress): Prevent file being locked on rename
SystemKeeper Apr 18, 2025
deab647
fix(cypress): Reload page after adding a comment
SystemKeeper Apr 18, 2025
49c452a
test(cypress): Expose container port
artonge May 22, 2025
611c2b5
chore: Bump @nextcloud/cypress to v1.0.0-beta15
artonge May 22, 2025
6d3f773
test(cypress): Enable test isolation
artonge May 22, 2025
fca2fa1
test(tag): Ensure tag does not already exists in the server
artonge May 22, 2025
ac5d4dd
test(share): Ensure file list row is visible
artonge May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(share): Ensure file list row is visible 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed May 26, 2025
commit ac5d4dd79d2d38af915c2ed8ebc5a5bb3fadfdbc
4 changes: 4 additions & 0 deletions cypress/e2e/filesUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ export function moveFile (fileName: string, dirName: string) {
})
}

export function getFileListRow(filename: string) {
return cy.get(`[data-cy-files-list] [data-cy-files-list-row-name="${CSS.escape(filename)}"]`)
}

export function toggleMenuAction(fileName: string) {
cy.get(`[data-cy-files-list] [data-cy-files-list-row-name="${CSS.escape(fileName)}"] [data-cy-files-list-row-actions]`)
.should('be.visible')
Expand Down
7 changes: 4 additions & 3 deletions cypress/e2e/sidebar.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { createFolder, navigateToFolder, moveFile, renameFile } from './filesUtils'
import { createFolder, navigateToFolder, moveFile, renameFile, getFileListRow } from './filesUtils'
import { addComment, addTag, addToFavorites, createPublicShare, randHash, removeFromFavorites, showActivityTab } from './sidebarUtils'

describe('Check activity listing in the sidebar', { testIsolation: true }, () => {
Expand Down Expand Up @@ -32,8 +32,9 @@ describe('Check activity listing in the sidebar', { testIsolation: true }, () =>

it('Has share activity', () => {
createPublicShare('welcome.txt')
cy.get('body').contains('Link share created').should('exist')
cy.get('.toast-close').click({ multiple: true })
cy.visit('/apps/files')
getFileListRow('welcome.txt').should('be.visible')

showActivityTab('welcome.txt')
cy.get('.activity-entry').first().should('contains.text', 'Shared as public link')
})
Expand Down
Loading