Skip to content

perf: pass the node of shares around instead getting the path from id each time #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icewind1991 merged 3 commits into from
Aug 13, 2025
Merged

perf: pass the node of shares around instead getting the path from id each time #2098

icewind1991 merged 3 commits into from
Aug 13, 2025

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Aug 11, 2025 •
edited
Loading

No need for a expensive by-id searches if the share event already has the node

@cypress
Copy link

cypress bot commented Aug 11, 2025 •
edited
Loading

Activity    Run #2770

Run Properties:  status check passed Passed #2770  •  git commit 05ec2385a8: perf: pass the node of shares source instead of re-fetching it's path
Project Activity
Branch Review share-hook-path
Run status status check passed Passed #2770
Run duration 02m 04s
Commit git commit 05ec2385a8: perf: pass the node of shares source instead of re-fetching it's path
Committer Robin Appelman
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@icewind1991
Copy link
Member Author

icewind1991 commented Aug 12, 2025

The entire FileHooks is a mess performance wise...

@icewind1991 icewind1991 marked this pull request as draft August 13, 2025 09:16
@icewind1991 icewind1991 changed the title perf: pass the path of link share source instead of re-calculating it perf: pass the node of shares source instead of re-fetching it's path Aug 13, 2025
@icewind1991 icewind1991 changed the title perf: pass the node of shares source instead of re-fetching it's path perf: pass the node of shares around instead getting the path from id each time Aug 13, 2025
@icewind1991 icewind1991 marked this pull request as ready for review August 13, 2025 13:39
@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Aug 13, 2025
@icewind1991 icewind1991 merged commit db380fa into master Aug 13, 2025
59 checks passed
@icewind1991 icewind1991 deleted the share-hook-path branch August 13, 2025 14:32
@icewind1991
Copy link
Member Author

icewind1991 commented Aug 13, 2025

/backport to stable31

@icewind1991
Copy link
Member Author

icewind1991 commented Aug 13, 2025

/backport to stable30

@backportbot backportbot bot mentioned this pull request Aug 13, 2025
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Aug 13, 2025
Closed
2 tasks
@icewind1991 icewind1991 mentioned this pull request Aug 14, 2025
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @st3iny @CarlSchwan @skjnldsv