Skip to content

[stable31] perf: pass the node of shares around instead getting the path from id each time #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 5 commits into from
Aug 14, 2025
Merged

[stable31] perf: pass the node of shares around instead getting the path from id each time #2101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e0ef25
perf: pass share node instead of fileid in sharing file hooks
icewind1991 Aug 11, 2025
377cce7
test: adjust tests to hook changes
icewind1991 Aug 13, 2025
844abf9
chore: update psalm stubs and baseline
icewind1991 Aug 13, 2025
8af5bca
fix: use target path for unshare-from-self events
icewind1991 Aug 14, 2025
bb03c49
test: add test for leave share activity
icewind1991 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update psalm stubs and baseline 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Aug 13, 2025
commit 844abf9241be24b394c41773ebc412c543bf66b6
1 change: 1 addition & 0 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<stubs>
<file name="tests/stubs/oc_hooks_emitter.php" />
<file name="tests/stubs/oca_files_event.php" preloadClasses="true" />
<file name="tests/stubs/oca_files_sharing.php" preloadClasses="true" />
<file name="tests/stubs/oca_viewer_event.php" preloadClasses="true" />
<file name="tests/stubs/oca_theming_defaults.php" preloadClasses="true" />
</stubs>
Expand Down
4 changes: 0 additions & 4 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@
<code><![CDATA[Member]]></code>
<code><![CDATA[protected]]></code>
</UndefinedClass>
<UndefinedDocblockClass>
<code><![CDATA[$shareOwner]]></code>
<code><![CDATA[$storage]]></code>
</UndefinedDocblockClass>
</file>
<file src="lib/Migration/Version2008Date20181011095117.php">
<UndefinedClass>
Expand Down
7 changes: 7 additions & 0 deletions tests/stubs/oca_files_sharing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

namespace OCA\Files_Sharing {
interface SharedMount extends \OCP\Files\Mount\IMountPoint {
public function getShare(): \OCP\Share\IShare;
}
}
Loading