fix(emails): catch server connection exceptions #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/2120/catch-user-backend-server-exceptions
branch
from
35f6cc9 to
41ecd5f
Compare
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/2120/catch-user-backend-server-exceptions
|
| Run status |
|
| Run duration | 04m 00s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
artonge
approved these changes
Nov 14, 2025
Comment on lines
+66
to
+69
| * @param int $limit Number of users we want to send an email to | ||
| * @param int $sendTime The latest send time | ||
| * @param bool $forceSending Ignores latest send and just sends all emails | ||
| * @param int|null $restrictEmails null or one of UserSettings::EMAIL_SEND_*, will overwrite force send |
This was referenced Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2120
Handle the case where the user backend isn't reachable.
Currently, the exception breaks hard when the user backend throws an
\Exceptionand thus, already sent activity emails don't get deleted and are resent on the next batch.Catching the exception and logging it instead at least doesn't lead to multiple emails being sent.