Don't add empty entries to the objects array #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Member
tobiasKaminsky
left a comment
tobiasKaminsky
left a comment
There was a problem hiding this comment.
Tested and works fine with latest master 👍
nickvergessen
deleted the
bugfix/noid/dont-add-empty-entries-to-objects-array
branch
Member
|
Will this be backported? It is quite a problem on Android if no activities at all are shown. |
Member
Author
|
Backport doesnt help as releases just went out and it would be broken 4-6 more weeks. |
Member
Author
|
/backport to stable15 |
|
backport to stable15 in #347 |
Member
|
Then I'll add a fix to Android 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]