Skip to content

Conversation

@kokspflanze
Copy link
Contributor

@kokspflanze kokspflanze commented Nov 20, 2019

if you set blacklisted_files in your config like

'blacklisted_files' => [
    '.htaccess',
    'Thumbs.db',
    'thumbs.db',
],

than is the is_dir parameter null but the getPreviewLink method require a bool, so it generate a error and the activity page hangs.

@nickvergessen
Copy link
Member

Can you instead add a casting to boolean in the ViewInfoCache class when we set the value?
Thanks a lot

@nickvergessen
Copy link
Member

/backport to stable17

@nickvergessen
Copy link
Member

/backport to stable16

@kokspflanze
Copy link
Contributor Author

@nickvergessen i was thinking about this too, but i was thinking null is needed to know if a file is blacklisted.

but i will change it

@kokspflanze kokspflanze removed their assignment Nov 26, 2019
@backportbot-nextcloud
Copy link

backport to stable17 in #407

@kokspflanze kokspflanze deleted the patch-is_dir-can-be-null branch November 27, 2019 06:36
@nickvergessen
Copy link
Member

/backport to stable16

@backportbot-nextcloud
Copy link

backport to stable16 in #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants