-
Notifications
You must be signed in to change notification settings - Fork 68
is_dir can be null on blacklisted files #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nickvergessen
merged 2 commits into
nextcloud:master
from
kokspflanze:patch-is_dir-can-be-null
Nov 26, 2019
Merged
is_dir can be null on blacklisted files #406
nickvergessen
merged 2 commits into
nextcloud:master
from
kokspflanze:patch-is_dir-can-be-null
Nov 26, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KoKsPfLaNzE <[email protected]>
Member
|
Can you instead add a casting to boolean in the |
Member
|
/backport to stable17 |
Member
|
/backport to stable16 |
Contributor
Author
|
@nickvergessen i was thinking about this too, but i was thinking null is needed to know if a file is blacklisted. but i will change it |
nickvergessen
approved these changes
Nov 26, 2019
|
backport to stable17 in #407 |
Member
|
/backport to stable16 |
|
backport to stable16 in #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you set blacklisted_files in your config like
than is the
is_dirparameter null but thegetPreviewLinkmethod require a bool, so it generate a error and the activity page hangs.