Skip to content

Fix the comments added to the activity table #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Oct 7, 2020
Merged

Fix the comments added to the activity table #510

nickvergessen merged 1 commit into from
Oct 7, 2020

Conversation

@sharidas
Copy link

@sharidas sharidas commented Oct 6, 2020

When user adds comments to a file, the activity
notifications were not updated. This change does
fix the issue.

Signed-off-by: Sujith Haridasan [email protected]

@sharidas sharidas self-assigned this Oct 6, 2020
@sharidas sharidas linked an issue Oct 6, 2020 that may be closed by this pull request
Comments are not shown in activity stream anymore? #498
Closed
@sharidas
Copy link
Author

sharidas commented Oct 6, 2020 •
edited
Loading

Summary

The comments added for files were missing in the activity app.

Description

The comments added for the files were working in stable19 branch but were found to be not working in stable20 branch. This change helps to fix the issue.
Note: The reason I took this approach because looking at the code, I am under the impression that its the notification we want to control from the admin setting or the user setting. So if the activity app is enabled, the activity would log the comments for the files even if the notifications are disabled for the comments in the web ui. Let me know if this look ok.

How was tested?

  • Enable activity app
  • Add a file to the Filesystem
  • Add a comment to the file
  • Navigate to the activity tab of the file, the comment is seen, just like stable19.

@sharidas sharidas force-pushed the fix-comment-activity-event branch from f9c041c to 6ee8b9b Compare October 7, 2020 06:51
nickvergessen
nickvergessen requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it should be.
Currently your own comments are missing, but with your current change the comments of others would be missing.

@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Oct 7, 2020
@sharidasan
Fix the comments added to the activity table
f964742 
When user adds comments to a file, the activity
notifications were not updated. This change does
fix the issue.

Signed-off-by: Sujith Haridasan <[email protected]>
@sharidas sharidas force-pushed the fix-comment-activity-event branch from 6ee8b9b to f964742 Compare October 7, 2020 07:35
@nickvergessen
Copy link
Member

nickvergessen commented Oct 7, 2020

/backport to stable20

@nickvergessen nickvergessen merged commit 881b16f into nextcloud:master Oct 7, 2020
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@sharidas sharidas

Labels

3. to review bug feature: stream

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

Comments are not shown in activity stream anymore?

3 participants

@sharidas @nickvergessen @sharidasan