Skip to content

Add dedicated activities for file uploads to public shares #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MorrisJobke wants to merge 1 commit into from
Closed

Add dedicated activities for file uploads to public shares #568

MorrisJobke wants to merge 1 commit into from

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 25, 2021

The events are handled in the files app: nextcloud/server#26300

@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone Mar 25, 2021
@MorrisJobke MorrisJobke mentioned this pull request Mar 25, 2021
Closed
@MorrisJobke MorrisJobke requested a review from icewind1991 March 25, 2021 15:55
@nickvergessen
Copy link
Member

nickvergessen commented Mar 25, 2021

But maybe I didn't upload but only create it on the instance with the existing options in the + menu?

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 25, 2021

But maybe I didn't upload but only create it on the instance with the existing options in the + menu?

Which is still fine to be handled as "Uploaded a template"?

@nickvergessen
Copy link
Member

nickvergessen commented Mar 25, 2021

Another thing to consider, it does not group anymore.
So when you have a sync client and dump in a folder with 3 subfolder and 3 files each, you get 6 activity rows instead of 1?

@MorrisJobke MorrisJobke deleted the enh/noid/improved-public-link-activities branch May 18, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke @nickvergessen