Fix group move/rename activities #693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2022 21:44
This is only preparation for implementing notifications for group members in case of moving, renaming and sharing which is currently missing. This doesn't include any changes to the logic. Signed-off-by: Chris Fritsche <[email protected]> Signed-off-by: Frieder Schrempf <[email protected]>
Signed-off-by: Chris Fritsche <[email protected]> Signed-off-by: Frieder Schrempf <[email protected]>
fschrempf
force-pushed
the
fix-group-move-rename-activities
branch
from
815565d to
cacdb3d
Compare
This was referenced Jan 4, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
This was referenced May 3, 2023
Collaborator
|
Seems covered by #1163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a respin of #500. The code is essentially the same, but with a few small style fixes and rebased and tested on master of server, activities app and groupfolders app.
This still doesn't cover the handling of sharing events for other groupfolder users. So it only partly solves nextcloud/groupfolders#1018.
Cc: @chrisfritsche