Skip to content

Save parameters also in the notifications #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
May 30, 2022
Merged

Save parameters also in the notifications #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Save parameters also in the notifications 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed May 24, 2022
commit 3f823a25fcc0fe31099b4adcb121df152a7728ad
6 changes: 3 additions & 3 deletions lib/NotificationGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private function getNotificationForEvent(IEvent $event, int $activityId): INotif
$notification->setUser($event->getAffectedUser());
$notification->setDateTime(\DateTime::createFromFormat('U', (string)$event->getTimestamp()));
$notification->setObject('activity_notification', (string)$activityId);
$notification->setSubject($event->getSubject());
$notification->setSubject($event->getSubject(), $event->getSubjectParameters());

if ($event->getRichSubject()) {
$notification->setRichSubject($event->getRichSubject(), $event->getRichSubjectParameters());
Expand All @@ -79,7 +79,7 @@ private function getNotificationForEvent(IEvent $event, int $activityId): INotif
}

if ($event->getMessage()) {
$notification->setMessage($event->getMessage());
$notification->setMessage($event->getMessage(), $event->getMessageParameters());
}

if ($event->getLink()) {
Expand Down Expand Up @@ -141,7 +141,7 @@ private function getDisplayNotificationForEvent(IEvent $event, int $activityId):
}

if ($event->getParsedMessage()) {
$notification->setParsedSubject($event->getParsedSubject());
$notification->setParsedMessage($event->getParsedMessage());
}

return $notification;
Expand Down