Skip to content

Conversation

@szaimen
Copy link
Collaborator

@szaimen szaimen commented Nov 14, 2025

As mentioned here: nextcloud/app_api#699 (comment)

@szaimen szaimen added this to the next milestone Nov 14, 2025
@szaimen szaimen added 3. to review Waiting for reviews bug Something isn't working labels Nov 14, 2025
@apparle
Copy link
Collaborator

apparle commented Nov 15, 2025

Is this really necessary?
From what I read in changelog for v1.44 and v1.45, only the GET method's value for Aliases in the returned payload is changing.
We use the POST method, and I believe there's no change for that. I see even API version v1.52 supports Aliases in the payload

My key concern is that this may break podman compatibility; hard to locate the exact documentation on exact version compatibility.. Might be easier to stay on older Aliases field for maximum backward compatibility if it's still valid in newer docker engine versions.

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 17, 2025

Is this really necessary? From what I read in changelog for v1.44 and v1.45, only the GET method's value for Aliases in the returned payload is changing. We use the POST method, and I believe there's no change for that. I see even API version v1.52 supports Aliases in the payload

My key concern is that this may break podman compatibility; hard to locate the exact documentation on exact version compatibility.. Might be easier to stay on older Aliases field for maximum backward compatibility if it's still valid in newer docker engine versions.

Thanks for the feedback! I agree to close this then...

@szaimen szaimen closed this Nov 17, 2025
@szaimen szaimen deleted the enh/noid/switch-to-dns-names branch November 17, 2025 15:23
@szaimen szaimen removed this from the next milestone Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants