Update Toolchain/Android-Target to v24 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
force-pushed
the
build24
branch
from
cef8ddc to
5269566
Compare
Member
Author
|
cc: @tobiasKaminsky and @nextcloud/android for review. |
AndyScherzinger
force-pushed
the
build24
branch
3 times, most recently
from
193779c to
3021c14
Compare
Member
Author
|
@tobiasKaminsky is it okay for you if I merge this, create a new version 1.0.8 to use in my app branch to work on the general v25 version bump? |
AndyScherzinger
force-pushed
the
build24
branch
from
3021c14 to
2cbab1d
Compare
AndyScherzinger
force-pushed
the
build24
branch
from
3f31e90 to
263f526
Compare
AndyScherzinger
force-pushed
the
build24
branch
from
263f526 to
9440565
Compare
AndyScherzinger
force-pushed
the
build24
branch
2 times, most recently
from
50bee26 to
91b4ec0
Compare
Member
|
Let's do in parallel with app 1.4.0. |
| <resources> | ||
|
|
||
| <string name="app_name">Oc_framework-testTest</string> | ||
| <string name="app_name">Nc_framework-testTest</string> |
Member
|
code wise 👍 |
tobiasKaminsky
previously requested changes
Oct 19, 2016
| environment: | ||
| - ANDROID_TARGET=android-24 | ||
| - ANDROID_ABI=armeabi-v7a | ||
| - LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/:/opt/android-sdk-linux/tools/lib64/gles_mesa/ |
Member
There was a problem hiding this comment.
Is this whole drone.yml up to date?
Member
Author
There was a problem hiding this comment.
Will have to check, but I thought so
Member
Author
There was a problem hiding this comment.
Yes, this one is fine :)
AndyScherzinger
force-pushed
the
build24
branch
from
e633b0f to
769fbfb
Compare
AndyScherzinger
changed the title
AndyScherzinger
changed the title
Member
Author
|
@tobiasKaminsky anything else to do here in your opinion? |
AndyScherzinger
dismissed
tobiasKaminsky’s stale review
as discussed, this is no issue
Member
Author
|
merging... 👍 The thing missing in the build file is since we do not have a server yet to run integration tests on... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump everything to 24 so the app project can then move to v24 to support Android N.