-
Notifications
You must be signed in to change notification settings - Fork 95
Gallery search #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery search #147
Conversation
|
code-wise it looks fine to me, is there a corresponding app branch where this is integrated? |
|
@AndyScherzinger I just did a quick hack for the app to test this while developing, there's no corresponding app branch since someone else will have to do it. The reason is that over a year ago we agreed to merge videos+photos into a Gallery both into iOS and Android, so I had to see how to do it. This PR is the result of it :) |
|
@mario could you just push your hack to a branch on the app repo, that we I/we would have an impression of how to integrate and could pick it up from there :) That be of great help :) |
|
@AndyScherzinger I deleted this as it was literally a few lines change to send GALLERY_SEARCH over to the SearchOperation. :-/ |
|
After release of 3.2 I can have a look to implement it in app. |
|
Well, didn't we talk about search pagination and caching the proper way @icewind1991? :P |
|
@tobiasKaminsky @mario for whatever reason the iOS client is super fast for this view?! |
|
There is already some work done by Roeland and me: nextcloud/android#2250 |
@tobiasKaminsky iOS is super fast now! Not needing any Nc14 stuff, so that doesn't matter it seems that this can be solved today... |
|
nextcloud/ios#583 |
|
I need review on this @AndyScherzinger @tobiasKaminsky @ardevd |
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
Signed-off-by: Mario Danic <[email protected]>
58b4cae to
b40082f
Compare
Videos + Photos need to be merged into one item as gallery. This adds library support for it.
cc @ardevd @AndyScherzinger @tobiasKaminsky