Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky [email protected]

AndyScherzinger
AndyScherzinger previously approved these changes May 8, 2019
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings42
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings22
Security Warnings17
Dodgy code Warnings84
Total195

FindBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings42
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings22
Security Warnings17
Dodgy code Warnings84
Total195

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #291 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #291      +/-   ##
=========================================
- Coverage   16.92%   16.9%   -0.02%     
=========================================
  Files         120     120              
  Lines        5224    5229       +5     
  Branches      719     720       +1     
=========================================
  Hits          884     884              
- Misses       4213    4218       +5     
  Partials      127     127
Impacted Files Coverage Δ
...oud/android/lib/resources/status/OCCapability.java 0% <0%> (ø) ⬆️
...sources/status/GetRemoteCapabilitiesOperation.java 0% <0%> (ø) ⬆️

@tobiasKaminsky
Copy link
Member Author

@AndyScherzinger I cannot see your review comment, do you recall what it was?

@AndyScherzinger
Copy link
Member

Unfortunately,no. :/

@AndyScherzinger AndyScherzinger merged commit b15a976 into master May 9, 2019
@AndyScherzinger AndyScherzinger deleted the richDocumentsProductName branch May 9, 2019 20:47
@AndyScherzinger AndyScherzinger added this to the NC Android lib 1.5.0 milestone May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants