Change sharees format #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 21.58% 25.38% +3.79%
==========================================
Files 117 118 +1
Lines 5166 5220 +54
Branches 701 711 +10
==========================================
+ Hits 1115 1325 +210
+ Misses 3921 3735 -186
- Partials 130 160 +30
|
AndyScherzinger
previously approved these changes
Aug 1, 2019
4 tasks
AndyScherzinger
previously approved these changes
Aug 6, 2019
Member
Author
This currently cannot work as server PR needs first to be merged. |
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
dcc2611 to
5f30580
Compare
AndyScherzinger
previously approved these changes
Aug 19, 2019
tobiasKaminsky
force-pushed
the
adaptSharees
branch
2 times, most recently
from
20ee387 to
cb58df5
Compare
| } | ||
|
|
||
| private @Nullable | ||
| ShareeUser createShareeUser(Element element) { |
Member
There was a problem hiding this comment.
should be a single line
private @Nullable ShareeUser createShareeUser(Element element) {
AndyScherzinger
previously approved these changes
Aug 20, 2019
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
just a minor formatting comment
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
f14b00e to
bd47e7e
Compare
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
bd47e7e to
1e7e1f6
Compare
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1180 |
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
1e7e1f6 to
f592545
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1182 |
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
f592545 to
14f2b85
Compare
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1183 |
tobiasKaminsky
force-pushed
the
adaptSharees
branch
3 times, most recently
from
69b1246 to
828e6a9
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
828e6a9 to
e2b8892
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
e2b8892 to
c425a43
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
Lint increased! |
- add ShareeUser, with userId and displayName - add tests - add group support - no need of own hashCode create user/group in drone Signed-off-by: tobiasKaminsky <[email protected]>
tobiasKaminsky
force-pushed
the
adaptSharees
branch
from
c425a43 to
a219fbe
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: nextcloud/server#14429
Only merge if this is in NC17, otherwise change it.
Needs new server image, as it needs
user1, displayName: "User One"
user2, displayName: "User Two"
users group: with user1, user2
Signed-off-by: tobiasKaminsky [email protected]