Skip to content

Conversation

@nicofrand
Copy link
Contributor

This fixes the android part of #12138.
The webview part needs some tweaking but can already be used with this PR for testing: https://github.com/nicofrand/nextcloud-text/commits/fixReconnect/.

I am quite new to android development and brand new to this app (thanks @juliushaertl for all the help already). I don't know if tests should be added or how to put them. I am open to discussion ofc.

To test (see #12138):

  • Tests written, or not not needed

@nicofrand nicofrand force-pushed the reloadDirectEditing branch from d91ed25 to 70b1597 Compare April 9, 2024 08:04
@juliusknorr juliusknorr added bug 3rdparty An upstream, OS, dependency, or other third-party matter labels Apr 12, 2024
@juliusknorr
Copy link
Member

@nicofrand Maybe you can also already open a pull request for the text part for easier testing and early review :)

@nicofrand
Copy link
Contributor Author

@nicofrand Maybe you can also already open a pull request for the text part for easier testing and early review :)

Done: nextcloud/text#5662
There are still things to improve though on the Text app side.

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@nicofrand
Copy link
Contributor Author

It's a bit ironic to get a survey about a pull request that did not receive any feedback…

@nicofrand
Copy link
Contributor Author

Anyone for a review?

@dbolton
Copy link

dbolton commented Jun 2, 2024

This is one of the top Nextcloud bugs for me. I encounter it multiple times a day.

@tobiasKaminsky
Copy link
Member

Moved to #13247, so that CI can work.

@tobiasKaminsky
Copy link
Member

Thanks for this fix, @nicofrand 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rdparty An upstream, OS, dependency, or other third-party matter 3. to review bug feature: editor feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants