Skip to content

show outdated warning depending on subscription key #15772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alperozturk96 merged 3 commits into from
Nov 5, 2025
Merged

show outdated warning depending on subscription key #15772

alperozturk96 merged 3 commits into from
Nov 5, 2025

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 10, 2025

  • Tests written, or not not needed

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 🤖 🍏 Mobile clients team Oct 20, 2025
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 🤖 🍏 Mobile clients team Oct 20, 2025
@tobiasKaminsky tobiasKaminsky mentioned this pull request Oct 22, 2025
Merged
@tobiasKaminsky tobiasKaminsky force-pushed the sub branch 2 times, most recently from 12c7818 to dd9a2d3 Compare October 28, 2025 07:05
AndyScherzinger
AndyScherzinger approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Codacy

Lint

TypemasterPR
Warnings4141
Errors1111

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7373
Dodgy code266267
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total492493

SpotBugs increased!

@alperozturk96
Copy link
Collaborator

alperozturk96 commented Oct 30, 2025 •
edited
Loading

@tobiasKaminsky It has conflict due to new changes. Also, I updated the DB version to 94.

First, we can check this PR: #15824 then you can rebase?

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Nov 5, 2025

/backport to stable-3.34

tobiasKaminsky and others added 3 commits November 5, 2025 11:12
@tobiasKaminsky @alperozturk96
show outdated warning depending on subscription key
1965ad1 
Signed-off-by: tobiasKaminsky <[email protected]>

# Conflicts:
#	app/schemas/com.nextcloud.client.database.NextcloudDatabase/94.json
#	app/src/main/java/com/nextcloud/client/database/entity/CapabilityEntity.kt
#	build.gradle
@tobiasKaminsky @alperozturk96
show warning only within app, due to login flow v2 other is barely vi…
4e7699d 
…sible

Signed-off-by: tobiasKaminsky <[email protected]>
@alperozturk96
fix git conflict
2391368 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 merged commit 9602b40 into master Nov 5, 2025
10 of 19 checks passed
@alperozturk96 alperozturk96 deleted the sub branch November 5, 2025 10:19
@backportbot backportbot bot mentioned this pull request Nov 5, 2025
Merged
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15772.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@alperozturk96 alperozturk96 alperozturk96 approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @alperozturk96 @AndyScherzinger