Skip to content

skip auto rename and filename validator if wcf disabled #15824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 5 commits into from
Nov 5, 2025
Merged

skip auto rename and filename validator if wcf disabled #15824

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
567eefa
skip auto rename if wcf disabled
alperozturk96 Oct 21, 2025
549fd05
fix tests
alperozturk96 Oct 21, 2025
0854892
solve git conflict
alperozturk96 Oct 30, 2025
3006898
fix condition and add tests
alperozturk96 Oct 29, 2025
c136c2e
use NextcloudVersion
alperozturk96 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use NextcloudVersion 
Signed-off-by: alperozturk <[email protected]>
  • Loading branch information
@alperozturk96
alperozturk96 committed Nov 5, 2025
commit c136c2e7b0d1fb64870b57f5f52596d9958397b4
37 changes: 9 additions & 28 deletions app/src/androidTest/java/com/nextcloud/utils/CheckWCFRestrictionsTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package com.nextcloud.utils

import com.nextcloud.utils.extensions.checkWCFRestrictions
import com.owncloud.android.lib.resources.status.CapabilityBooleanType
import com.owncloud.android.lib.resources.status.NextcloudVersion
import com.owncloud.android.lib.resources.status.OCCapability
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
Expand All @@ -16,67 +17,47 @@ import org.junit.Test
@Suppress("MagicNumber")
class CheckWCFRestrictionsTests {

private val version29 = Triple(29, 0, 0)
private val version30 = Triple(30, 0, 0)
private val version31 = Triple(31, 0, 0)
private val version32 = Triple(32, 0, 0)
private val version33 = Triple(33, 0, 0)

private fun createCapability(
version: Triple<Int, Int, Int>,
version: NextcloudVersion,
isWCFEnabled: CapabilityBooleanType = CapabilityBooleanType.UNKNOWN
): OCCapability = OCCapability().apply {
this.versionMayor = version.first
this.versionMinor = version.second
this.versionMicro = version.third
this.versionMayor = version.majorVersionNumber
this.isWCFEnabled = isWCFEnabled
}

@Test
fun testReturnsFalseForVersionsOlderThan30() {
val capability = createCapability(version29)
val capability = createCapability(NextcloudVersion.nextcloud_29)
assertFalse(capability.checkWCFRestrictions())
}

@Test
fun testReturnsTrueForVersion30WhenWCFAlwaysEnabled() {
val capability = createCapability(version30)
val capability = createCapability(NextcloudVersion.nextcloud_30)
assertTrue(capability.checkWCFRestrictions())
}

@Test
fun testReturnsTrueForVersion31WhenWCFAlwaysEnabled() {
val capability = createCapability(version31)
val capability = createCapability(NextcloudVersion.nextcloud_31)
assertTrue(capability.checkWCFRestrictions())
}

@Test
fun testReturnsTrueForVersion32WhenWCFEnabled() {
val capability = createCapability(version32, CapabilityBooleanType.TRUE)
val capability = createCapability(NextcloudVersion.nextcloud_32, CapabilityBooleanType.TRUE)
assertTrue(capability.checkWCFRestrictions())
}

@Test
fun testReturnsFalseForVersion32WhenWCFDisabled() {
val capability = createCapability(version32, CapabilityBooleanType.FALSE)
val capability = createCapability(NextcloudVersion.nextcloud_32, CapabilityBooleanType.FALSE)
assertFalse(capability.checkWCFRestrictions())
}

@Test
fun testReturnsFalseForVersion32WhenWCFIsUnknown() {
val capability = createCapability(version32)
assertFalse(capability.checkWCFRestrictions())
}

@Test
fun testReturnsTrueForNewerVersionWhenWCFEnabled() {
val capability = createCapability(version33, CapabilityBooleanType.TRUE)
assertTrue(capability.checkWCFRestrictions())
}

@Test
fun testReturnsFalseForNewerVersionWhenWCFDisabled() {
val capability = createCapability(version33, CapabilityBooleanType.FALSE)
val capability = createCapability(NextcloudVersion.nextcloud_32)
assertFalse(capability.checkWCFRestrictions())
}
}
Loading