Ensure images always have a contentDescription
#16356
Open
+79
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case it is decorative Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
fix/noid/imageContentDescription
branch
from
eb37805 to
901a52d
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16356.apk |
Member
|
Hello, From my side, that's OK. |
Member
Author
|
Thanks for the swift feedback @rakekniven 🙏 Plan would be to release or around the Hub release, hence around 18th February 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... or
nullin case it is decorative.adding @rakekniven for approval, because we have a string-freeze for Hub 26 Winter and merging this would add some new Strings which is bad for translation completeness but good from an accessibility point of view. See below.
(I didn't find the string to be in need of a descriptive translator comment, but if so, please let me know and I add them)
This info is important for screenreaders, so hard-coded strings should not be used but values in
string.xmlso there is no mix of languages when read to the users using screeenreader.