Create UserAccountManager and move getAccounts()

[ezaquarii]

Signed-off-by: Chris Narkiewicz [email protected]

[codecov]

Codecov Report

Merging #3895 into master will increase coverage by 0.05%.
The diff coverage is 26.42%.

@@             Coverage Diff             @@
##             master   #3895      +/-   ##
===========================================
+ Coverage      6.41%   6.46%   +0.05%     
  Complexity        1       1              
===========================================
  Files           323     325       +2     
  Lines         31220   31247      +27     
  Branches       4477    4479       +2     
===========================================
+ Hits           2002    2021      +19     
- Misses        28921   28930       +9     
+ Partials        297     296       -1

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
.../owncloud/android/authentication/AccountUtils.java	46.03% <ø> (+22.26%)	0 <0> (ø)	⬇️
...java/com/owncloud/android/jobs/OfflineSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/activity/UploadListActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ava/com/owncloud/android/jobs/NotificationJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/activity/UserInfoActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/ui/adapter/AccountListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...n/java/com/owncloud/android/jobs/FilesSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ain/java/com/owncloud/android/ui/TextDrawable.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...m/nextcloud/client/account/UserAccountManager.java	0% <0%> (ø)	0 <0> (?)
... and 24 more

[codecov]

Codecov Report

Merging #3895 into master will increase coverage by 0.05%.
The diff coverage is 26.81%.

@@             Coverage Diff             @@
##             master   #3895      +/-   ##
===========================================
+ Coverage      6.41%   6.46%   +0.05%     
  Complexity        1       1              
===========================================
  Files           323     325       +2     
  Lines         31220   31245      +25     
  Branches       4477    4478       +1     
===========================================
+ Hits           2002    2021      +19     
- Misses        28921   28928       +7     
+ Partials        297     296       -1

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
.../owncloud/android/authentication/AccountUtils.java	46.03% <ø> (+22.26%)	0 <0> (ø)	⬇️
...ain/java/com/owncloud/android/ui/TextDrawable.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/activity/UploadListActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ava/com/owncloud/android/jobs/NotificationJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/activity/UserInfoActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/ui/adapter/AccountListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...n/java/com/owncloud/android/jobs/FilesSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...java/com/owncloud/android/jobs/OfflineSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...m/nextcloud/client/account/UserAccountManager.java	0% <0%> (ø)	0 <0> (?)
... and 24 more

[ezaquarii]

Due ot large amount of global state accessed via static getters, the app has absolutely insane amount of circular dependencies that we try to break right now using Dependency Injection.

The problem is that if you touch anything, SpotBugs will most likely find new circular dependencies (and forget others), making PR landing rather tricky.

I decided do suppress FCCD_FIND_CLASS_CIRCULAR_DEPENDENCY SpotBugs error for now, because:

1. it is quite unmanageable anyway
2. it will be improved as a side effect of DI

For the time being, breaking those circlular deps causes linter to find more of them, which is an observation of limited use.

[ezaquarii]

BTW, FindBugs suffered from the same issue - there is no regression here.

[ezaquarii]

Analysis died:

Exception analyzing com.owncloud.android.ui.adapter.TrashbinListAdapter using detector com.mebigfatguy.fbcontrib.detect.FunctionalInterfaceIssues 
java.lang.ClassCastException: org.apache.bcel.classfile.BootstrapMethods cannot be cast to org.apache.bcel.classfile.Unknown 

I'm not sure if it's me or flaky check.

[nextcloud-android-bot]

Codacy

277

Lint

Type	master	PR
Warnings	57	57
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	84
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	48
Dodgy code Warnings	132
Total	441

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	114
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	48
Dodgy code Warnings	131
Total	470