Create service to handle what's new functionality #3898

ezaquarii · 2019-04-14T13:29:05Z

No description provided.

codecov · 2019-04-15T04:34:15Z

Codecov Report

Merging #3898 into master will increase coverage by 0.06%.
The diff coverage is 13.54%.

@@             Coverage Diff             @@
##             master   #3898      +/-   ##
===========================================
+ Coverage      6.45%   6.52%   +0.06%     
  Complexity        1       1              
===========================================
  Files           325     328       +3     
  Lines         31247   31301      +54     
  Branches       4479    4481       +2     
===========================================
+ Hits           2018    2042      +24     
- Misses        28931   28963      +32     
+ Partials        298     296       -2

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java	`6.74% <ø> (+0.02%)`	`0 <0> (ø)`	⬇️
...i/activities/data/files/RemoteFilesRepository.java	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
...m/nextcloud/client/account/UserAccountManager.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...m/owncloud/android/ui/adapter/TemplateAdapter.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...ndroid/ui/dialog/ChooseTemplateDialogFragment.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...oud/android/ui/activity/NotificationsActivity.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
.../owncloud/android/files/services/FileUploader.java	`0.2% <0%> (ø)`	`0 <0> (ø)`	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...com/owncloud/android/ui/activity/BaseActivity.java	`1.35% <0%> (-0.02%)`	`0 <0> (ø)`
... and 56 more

codecov · 2019-04-15T04:34:15Z

Codecov Report

Merging #3898 into master will increase coverage by 0.04%.
The diff coverage is 22.91%.

@@             Coverage Diff             @@
##             master   #3898      +/-   ##
===========================================
+ Coverage      6.57%   6.62%   +0.04%     
  Complexity        1       1              
===========================================
  Files           322     326       +4     
  Lines         30922   30912      -10     
  Branches       4409    4408       -1     
===========================================
+ Hits           2034    2048      +14     
+ Misses        28592   28569      -23     
+ Partials        296     295       -1

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
.../android/authentication/AuthenticatorActivity.java	`1.89% <ø> (ø)`	`0 <0> (ø)`	⬇️
...ndroid/ui/asynctasks/LoadingVersionNumberTask.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...om/nextcloud/client/whatsnew/WhatsNewActivity.java	`0% <0%> (ø)`	`0 <0> (?)`
...owncloud/android/ui/activity/FirstRunActivity.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...ud/android/providers/DocumentsStorageProvider.java	`1.06% <0%> (-0.01%)`	`0 <0> (ø)`
src/main/java/com/owncloud/android/MainApp.java	`47.51% <0%> (+1.31%)`	`0 <0> (ø)`	⬇️
...perations/DetectAuthenticationMethodOperation.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...d/authentication/AccountAuthenticatorActivity.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
... and 23 more

ezaquarii · 2019-04-15T20:17:14Z

com.owncloud.android.util.EncryptionTestIT is failing - I'm not sure if it's because I downgraded the lib to compile it.

AndyScherzinger · 2019-04-16T05:43:35Z

Latest master should work again 🤞

AndyScherzinger · 2019-04-30T09:20:43Z

@ezaquarii fine with me 👍
I am just waiting for @tobiasKaminsky's review/approval/merge 😃

AndyScherzinger · 2019-05-03T18:04:04Z

@ezaquarii any reason for closing? Unfortunately still waiting for @tobiasKaminsky's review 😣

ezaquarii · 2019-05-03T18:30:52Z

WhatsNewActivity has been removed recently, so I think this refactoring is obsolete now.

ezaquarii · 2019-05-03T18:32:10Z

I keep the branch around to salvage remaining pieces of logic that could be still applicable elsewhere.

AndyScherzinger · 2019-05-03T19:19:47Z

I think the activity should still be there but won't be called since we haven't had any new features worth propagating this way in the near past but might have in the future again.
Tobias knows best.

ezaquarii · 2019-05-04T17:15:01Z

Youp, I looked at this code once again and you are right. I'll rebase.

AndyScherzinger · 2019-05-06T15:14:01Z

needs another rebase due to the changed spotbugs score which is due to the latest findbugs lib update: #3955

AndyScherzinger · 2019-05-06T17:03:45Z

pinging @tobiasKaminsky for review/merge :) Looks good from my pov. 👍

nextcloud-android-bot · 2019-05-07T04:46:24Z

Codacy

277

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	174
Security Warnings	47
Dodgy code Warnings	141
Total	491

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	81
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	175
Security Warnings	47
Dodgy code Warnings	141
Total	497

Signed-off-by: Chris Narkiewicz <[email protected]>

… [skip ci] Signed-off-by: nextcloud-android-bot <[email protected]>

tobiasKaminsky · 2019-05-09T12:47:31Z

I rebased it to latest master and tested it.
Works as expected.

Thanks again @ezaquarii for this great PR 🎉

nextcloud-android-bot · 2019-05-09T13:24:11Z

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9113

nextcloud-android-bot · 2019-05-09T13:24:28Z

Codacy

278

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	174
Security Warnings	47
Dodgy code Warnings	141
Total	491

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	81
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	175
Security Warnings	47
Dodgy code Warnings	141
Total	497

ezaquarii added the 2. developing label Apr 14, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 227502d to 2f3724d Compare April 14, 2019 20:17

nextcloud deleted a comment Apr 14, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 2f3724d to 4357747 Compare April 15, 2019 04:34

nextcloud deleted a comment Apr 15, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 4357747 to 737feb7 Compare April 15, 2019 14:31

nextcloud deleted a comment Apr 15, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch 2 times, most recently from e1c527e to 62e6f87 Compare April 15, 2019 17:14

nextcloud deleted a comment Apr 15, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 62e6f87 to f6f199e Compare April 15, 2019 20:02

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from f6f199e to 239a79a Compare April 16, 2019 14:41

nextcloud deleted a comment Apr 16, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 239a79a to 76681a7 Compare April 16, 2019 18:40

nextcloud deleted a comment Apr 16, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 76681a7 to 5c803cf Compare April 16, 2019 18:56

nextcloud deleted a comment Apr 16, 2019

ezaquarii closed this May 3, 2019

ezaquarii reopened this May 4, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch 2 times, most recently from 401b9b6 to fedb895 Compare May 4, 2019 17:28

nextcloud deleted a comment May 4, 2019

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 28d2065 to 558e33c Compare May 6, 2019 15:23

ezaquarii force-pushed the ezaquarii/create-whats-new-service branch from 4fc993d to b757f25 Compare May 6, 2019 17:42

nextcloud deleted a comment May 6, 2019

nextcloud deleted a comment from ezaquarii May 6, 2019

ezaquarii and others added 2 commits May 9, 2019 14:43

Add AppInfo and WhatsNewService

f0554ab

Signed-off-by: Chris Narkiewicz <[email protected]>

Drone: update FindBugs results to reflect reduced error/warning count…

137e43e

… [skip ci] Signed-off-by: nextcloud-android-bot <[email protected]>

tobiasKaminsky force-pushed the ezaquarii/create-whats-new-service branch from 05c2994 to 137e43e Compare May 9, 2019 12:46

tobiasKaminsky approved these changes May 9, 2019

View reviewed changes

AndyScherzinger merged commit a727474 into master May 9, 2019

AndyScherzinger deleted the ezaquarii/create-whats-new-service branch May 9, 2019 20:43

AndyScherzinger added this to the Nextcloud App 3.7.0 milestone May 9, 2019

Uh oh!

Create service to handle what's new functionality #3898

Create service to handle what's new functionality #3898

Uh oh!

Conversation

ezaquarii commented Apr 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 15, 2019

Codecov Report

Uh oh!

codecov bot commented Apr 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ezaquarii commented Apr 15, 2019

Uh oh!

AndyScherzinger commented Apr 16, 2019

Uh oh!

AndyScherzinger commented Apr 30, 2019

Uh oh!

AndyScherzinger commented May 3, 2019

Uh oh!

ezaquarii commented May 3, 2019

Uh oh!

ezaquarii commented May 3, 2019

Uh oh!

AndyScherzinger commented May 3, 2019

Uh oh!

ezaquarii commented May 4, 2019

Uh oh!

AndyScherzinger commented May 6, 2019

Uh oh!

AndyScherzinger commented May 6, 2019

Uh oh!

nextcloud-android-bot commented May 7, 2019

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

Uh oh!

tobiasKaminsky commented May 9, 2019

Uh oh!

nextcloud-android-bot commented May 9, 2019

Uh oh!

nextcloud-android-bot commented May 9, 2019

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ezaquarii commented Apr 14, 2019 •

edited

Loading

codecov bot commented Apr 15, 2019 •

edited

Loading