added support for new image docker name format #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <[email protected]>
bigcat88
added a commit
to nextcloud/test-deploy
that referenced
this pull request
Aug 1, 2024
Signed-off-by: Alexander Piskun <[email protected]>
andrey18106
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, PR AppAPI only supported specifying Docker images in the following format:
ghcr.io/org-name/repostiry-name:tagghcr.io/org-name/repostiry-name-{COMPUTE_DEVIСE_TYPE}:tagSpecifying "COMPUTE_DEVIСE_TYPE" at the repository name level turned out to be very inconvenient:
${{ secrets.GITHUB_TOKEN }}from actions has access only to the repository, and to create actions for auto-publishing ExApps docker images, you had to create a custom github token for thatTherefore, starting with AppAPI 3.0, I propose to move COMPUTE_DEVIСE_TYPE in the package version:
ghcr.io/org-name/repostiry-name:tagghcr.io/org-name/repostiry-name:tag-{COMPUTE_DEVIСE_TYPE}We will leave support for the old type of COMPUTE_DEVIСE_TYPE indication for six months, so that everyone has time to update the ExApps in which they used COMPUTE_DEVIСE_TYPE.