Skip to content

Conversation

@andrey18106
Copy link
Contributor

@andrey18106 andrey18106 commented Oct 11, 2024

This PR synchronizes backend logic for ExAppFetcher and required changes for Apps management.

Screen Shot 2024-10-14 at 17 01 48

TODO

@andrey18106 andrey18106 requested a review from bigcat88 October 11, 2024 15:48
@andrey18106 andrey18106 changed the title chore: sync changes chore: sync changes for Apps management migration to settings Oct 11, 2024
@bigcat88 bigcat88 requested a review from julien-nc October 14, 2024 13:20
Copy link
Contributor

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't try it with the related server PR.
Do you want to include the changes dropping the UI stuff that is now in server? If so I'll wait for that to make another review.

@andrey18106
Copy link
Contributor Author

Looks good. I didn't try it with the related server PR. Do you want to include the changes dropping the UI stuff that is now in server? If so I'll wait for that to make another review.

Removed unused UI parts now.

@julien-nc julien-nc self-requested a review October 14, 2024 14:05
@andrey18106
Copy link
Contributor Author

/compile

@andrey18106
Copy link
Contributor Author

/backport to stable30

@andrey18106 andrey18106 merged commit b8200b7 into main Oct 29, 2024
@andrey18106 andrey18106 deleted the chore/fetcher/sync-changes branch October 29, 2024 19:26
andrey18106 added a commit that referenced this pull request Oct 30, 2024
…ngs (#428)

Backport of #417

Warning, This backport's changes differ from the original and might be
incomplete ⚠️

## Todo 
- [x] Review and resolve any conflicts
- [ ] Amend HEAD commit to remove the line stating to skip CI
---

Learn more about backports at
https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

---------

Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Co-authored-by: Andrey Borysenko <[email protected]>
Co-authored-by: nextcloud-command <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants