(fix): Encrypt sensitive values(haproxy_password) in the DB #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <[email protected]>
oleksandr-nc
force-pushed
the
fix/ecnrypt-sensetive-values
branch
from
39cbee6 to
5171441
Compare
kyteinsky
approved these changes
Nov 21, 2024
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
marcelklehr
reviewed
Nov 28, 2024
| $qbSelect = $this->connection->getQueryBuilder(); | ||
| $qbSelect->select(['id', 'deploy_config']) | ||
| ->from('ex_apps_daemons') | ||
| ->where(1); |
Member
There was a problem hiding this comment.
This breaks postgres due to type mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj. Added a migration for encryption, it needs to be executed manually for the master branch (I didn't increase the application version, because this branch will only be released with Nextcloud 31):
sudo -u www-data php occ migrations:execute app_api 5000Date20241120135411For backports, we will increase the application version, and in Nextcloud 30 or 29 nothing will need to be done manually.