Skip to content

fix: correct env var parsing when there is only one entry #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
Feb 12, 2025
Merged

fix: correct env var parsing when there is only one entry #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: correct env var parsing when there is only one entry 
Signed-off-by: Anupam Kumar <[email protected]>
  • Loading branch information
@kyteinsky
kyteinsky committed Feb 11, 2025
commit 7cd7ca19be4b672aa361e380b1c83dabb441d3cb
3 changes: 3 additions & 0 deletions lib/Service/ExAppService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,9 @@ public function getAppInfo(string $appId, ?string $infoXml, ?string $jsonInfo, ?
// Advanced deploy options
if (isset($appInfo['external-app']['environment-variables']['variable'])) {
$envVars = [];
if (!isset($appInfo['external-app']['environment-variables']['variable'][0])) {
$appInfo['external-app']['environment-variables']['variable'] = [$appInfo['external-app']['environment-variables']['variable']];
}
foreach ($appInfo['external-app']['environment-variables']['variable'] as $envVar) {
$envVars[$envVar['name']] = [
'name' => $envVar['name'],
Expand Down
Loading