Skip to content

Conversation

@oleksandr-nc
Copy link
Contributor

PR to speed up AppAPI for Nextcloud 32.

Each of the providers always added one extra request to the cache/DB for any request to the NC instance, which slows down the entire instance (a guess).

I completely cut them all out, they were deprecated in Nextcloud 30(?) (and a universal TaskProcessing provider was introduced).

@marcelklehr
Copy link
Member

It's a bit worrisome that we deprected only last year and are now removing this already, but since it's only in AppAPI, we could get away with it... Not sure if we need approval from Andy or somebody else

@julien-nc
Copy link
Member

Andy is fine with it as long as we have a TaskProcessing replacement for all the old API's providers implemented in exApps. And we have that, right?

@marcelklehr
Copy link
Member

Well the translation task type in task processing is not backward compatible with the old translate API, but other than that we're good.

@oleksandr-nc oleksandr-nc marked this pull request as ready for review March 25, 2025 18:54
@oleksandr-nc
Copy link
Contributor Author

Well the translation task type in task processing is not backward compatible with the old translate API, but other than that we're good.

But the old translate API has not been used anywhere since NC31?

@marcelklehr
Copy link
Member

But the old translate API has not been used anywhere since NC31?

Yeah, we're good :)

@oleksandr-nc oleksandr-nc merged commit 82d1c68 into main Mar 27, 2025
33 checks passed
@oleksandr-nc oleksandr-nc deleted the chore/remove-deprecated-AI-providers branch March 27, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants