Skip to content

[stable31] fix(Podman-HealthCheck): treat empty health status as success. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
Jun 4, 2025
Merged

[stable31] fix(Podman-HealthCheck): treat empty health status as success. #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions lib/DeployActions/DockerActions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,24 +803,26 @@ public function waitTillContainerStart(string $containerId, DaemonConfig $daemon

public function healthcheckContainer(string $containerId, DaemonConfig $daemonConfig, bool $waitForSuccess): bool {
$dockerUrl = $this->buildDockerUrl($daemonConfig);
$containerInfo = $this->inspectContainer($dockerUrl, $containerId);
if (!isset($containerInfo['State']['Health']['Status'])) {
return true; // container does not support Healthcheck
}
if (!$waitForSuccess) {
return $containerInfo['State']['Health']['Status'] === 'healthy';
}
$maxTotalAttempts = 900;
$maxTotalAttempts = $waitForSuccess ? 900 : 1;
while ($maxTotalAttempts > 0) {
$containerInfo = $this->inspectContainer($dockerUrl, $containerId);
if ($containerInfo['State']['Health']['Status'] === 'healthy') {
if (!isset($containerInfo['State']['Health']['Status'])) {
return true; // container does not support Healthcheck
}
$status = $containerInfo['State']['Health']['Status'];
if ($status === '') {
return true; // we treat empty status as 'success', see https://github.com/nextcloud/app_api/issues/439
}
if ($status === 'healthy') {
return true;
}
if ($containerInfo['State']['Health']['Status'] === 'unhealthy') {
if ($status === 'unhealthy') {
return false;
}
$maxTotalAttempts--;
sleep(1);
if ($maxTotalAttempts > 0) {
sleep(1);
}
}
return false;
}
Expand Down
Loading