Skip to content

Conversation

@andrey18106
Copy link
Contributor

@andrey18106 andrey18106 commented Aug 29, 2023

Attempt to implement dynamic registration of Speech-To-Text and Text processing APIs.

Due to technical obstacles one unresolved task left as there is no possibility in PHP to override ::class string, which is used for retrieving classes, implementing API interfaces widely used in Nextcloud.

  • Find out a way to properly resolve anonymous classes
  • Extract migration to a new one (as the previous one already released)
  • Add check for feature availability (since 29.0.0)

We can proceed with these APIs implementation after the following server PRs accepted and finished:

@andrey18106 andrey18106 requested a review from bigcat88 August 29, 2023 19:24
@andrey18106
Copy link
Contributor Author

Possible solution found with Julius, will update this PR later

@andrey18106
Copy link
Contributor Author

Current Text processing APIs in core requires adjustment in provider ID to use getId() method to identify unique provider registration like in other APIs, e.g. DashboardWidget (IWidget). Therefore current implementation would work only with single registration as in core it relies on $provider::class which in our case is anonymous class pointing to the line of code where it was created - so that multiple instances will not be handled properly.

@andrey18106 andrey18106 changed the title Text processing apis STT & Text processing APIs Oct 25, 2023
@andrey18106 andrey18106 added this to the Nextcloud 28 milestone Nov 1, 2023
@andrey18106 andrey18106 removed this from the Nextcloud 28 milestone Nov 28, 2023
Copy link
Contributor

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will implement all this in each separate PRs

@andrey18106
Copy link
Contributor Author

STT and Text-Processing are done and merged in separate PRs. Machine translation needs server side changes the same as for STT and Text-Processing, waiting for them and after that will add this API support here.

@andrey18106 andrey18106 closed this Jan 1, 2024
@bigcat88 bigcat88 deleted the text-processing-apis branch May 22, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants